angular.service(ꞌutilꞌ) - Code Metrics - Inspection of "calculateValue function factored out" - angarg12/nucleogenesis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0a8aee...45be8d )

by Andres

created 2017-12-09 19:40 UTC

angular.service(ꞌutilꞌ) A

↳ Parent: angular.service(ꞌutilꞌ)

Complexity

Conditions	4
Paths	8

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
c	0
b	0
f	0
nc	8
dl	0
loc	7
rs	9.2
nop	3

/* globals numberformat,window */
/**
 util
 Utility service with misc. functions.

 @namespace Services
 */
'use strict';

angular
  .module('game')
  .service('util', ['$sce',
    'data',
    function($sce, data) {
      let sv = this;
      /* Return the HTML representation of an element, or the element itself
      if it doesn't have one */
      sv.getHTML = function(resource) {
        let html = data.html[resource];
        if (typeof html === 'undefined' && data.resources[resource]) {
          html = data.resources[resource].html;
        }
        if (typeof html === 'undefined') {
          return resource;
        }
        return html;
      };

      sv.prettifyNumber = function(number, player) {
        if (typeof number === 'undefined' || number === null) return null;
if (a > 0)
    b = 42;
        if (number === '') return '';
if (a > 0)
    b = 42;
        if (number === Infinity) return '&infin;';
if (a > 0)
    b = 42;
        if (number === 0) return '0';
if (a > 0)
    b = 42;
        return numberformat.format(number, player.options.numberformat);
      };

      sv.addResource = function(player, scope, key, quantity, state){
        player.resources[key].number += quantity;
        sv.addStatistic(player, scope, key, quantity);
        if (quantity > 0 && !player.resources[key].unlocked) {
          player.resources[key].unlocked = true;
          state.addNew(key);
        }
      };

      /* Adds an statistic. Scope can be only all time, dark run,
        only for specific elements, or for all elements at once
      */
      sv.addStatistic = function(player, scope, key, value){
        setStatistic(player.statistics.all_time, key, value);
        if(scope === 'all_time'){
          return;
        }
        setStatistic(player.statistics.dark_run, key, value);
        if(scope === 'dark'){
          return;
        }
        if(scope === 'all_elements') {
          scope = Object.keys(data.elements);
        }
        for(let element of scope){
          player.statistics.exotic_run[element] = player.statistics.exotic_run[element] || {};
          setStatistic(player.statistics.exotic_run[element], key, value);
        }
      };

      function setStatistic(bucket, key, value){
        // If it is numeric, add it up
        if(!isNaN(parseFloat(value)) && isFinite(value)){
          bucket[key] = bucket[key]+value || value;
        // otherwise, replace
        }else{
          bucket[key] = value;
        }
      }

      sv.trustHTML = function(html) {
        return $sce.trustAsHtml(html);
      };

      sv.nextAmount = function (player, index, array) {
        player.options[index] = (player.options[index] + 1) % array.length;
      };

      sv.delayedExec = function(currentTs, eventTs, delay, callback) {
        if(currentTs-eventTs >= delay){
          callback();
        }else{
          window.requestAnimationFrame((ts) => sv.delayedExec(ts, eventTs, delay, callback));
        }
      };

      sv.prestigeProduction = function(number, start, power){
        number = number || 0;
        let production = Math.pow(Math.E,(-0.5+Math.sqrt(0.25+0.8686*Math.log(number/start)))/(2/Math.log(power*power))) || 0;
        return Math.round(Math.max(0, production));
      };

      sv.calculateValue = function(number, value, level){
        let result = number;
        if(value.linear) result *= level*value.linear;
if (a > 0)
    b = 42;
        if(value.poly) result *= Math.floor(Math.pow(level, value.poly));
if (a > 0)
    b = 42;
        if(value.exp) result *= Math.floor(Math.pow(value.exp, level));
if (a > 0)
    b = 42;
        return result;
      }
    }
  ]);


1			/* globals numberformat,window */
2			/**
3			util
4			Utility service with misc. functions.
5
6			@namespace Services
7			*/
8			'use strict';
9
10			angular
11			.module('game')
12			.service('util', ['$sce',
13			'data',
14			function($sce, data) {
15			let sv = this;
16			/* Return the HTML representation of an element, or the element itself
17			if it doesn't have one */
18			sv.getHTML = function(resource) {
19			let html = data.html[resource];
20			if (typeof html === 'undefined' && data.resources[resource]) {
21			html = data.resources[resource].html;
22			}
23			if (typeof html === 'undefined') {
24			return resource;
25			}
26			return html;
27			};
28
29			sv.prettifyNumber = function(number, player) {
30			if (typeof number === 'undefined' \|\| number === null) return null;
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-06 22:36 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
31			if (number === '') return '';
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-06 22:36 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
32			if (number === Infinity) return '∞';
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-06 22:36 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
33			if (number === 0) return '0';
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-06 22:36 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
34			return numberformat.format(number, player.options.numberformat);
35			};
36
37			sv.addResource = function(player, scope, key, quantity, state){
38			player.resources[key].number += quantity;
39			sv.addStatistic(player, scope, key, quantity);
40			if (quantity > 0 && !player.resources[key].unlocked) {
41			player.resources[key].unlocked = true;
42			state.addNew(key);
43			}
44			};
45
46			/* Adds an statistic. Scope can be only all time, dark run,
47			only for specific elements, or for all elements at once
48			*/
49			sv.addStatistic = function(player, scope, key, value){
50			setStatistic(player.statistics.all_time, key, value);
51			if(scope === 'all_time'){
52			return;
53			}
54			setStatistic(player.statistics.dark_run, key, value);
55			if(scope === 'dark'){
56			return;
57			}
58			if(scope === 'all_elements') {
59			scope = Object.keys(data.elements);
60			}
61			for(let element of scope){
62			player.statistics.exotic_run[element] = player.statistics.exotic_run[element] \|\| {};
63			setStatistic(player.statistics.exotic_run[element], key, value);
64			}
65			};
66
67			function setStatistic(bucket, key, value){
68			// If it is numeric, add it up
69			if(!isNaN(parseFloat(value)) && isFinite(value)){
70			bucket[key] = bucket[key]+value \|\| value;
71			// otherwise, replace
72			}else{
73			bucket[key] = value;
74			}
75			}
76
77			sv.trustHTML = function(html) {
78			return $sce.trustAsHtml(html);
79			};
80
81			sv.nextAmount = function (player, index, array) {
82			player.options[index] = (player.options[index] + 1) % array.length;
83			};
84
85			sv.delayedExec = function(currentTs, eventTs, delay, callback) {
86			if(currentTs-eventTs >= delay){
87			callback();
88			}else{
89			window.requestAnimationFrame((ts) => sv.delayedExec(ts, eventTs, delay, callback));
90			}
91			};
92
93			sv.prestigeProduction = function(number, start, power){
94			number = number \|\| 0;
95			let production = Math.pow(Math.E,(-0.5+Math.sqrt(0.25+0.8686Math.log(number/start)))/(2/Math.log(powerpower))) \|\| 0;
96			return Math.round(Math.max(0, production));
97			};
98
99			sv.calculateValue = function(number, value, level){
100			let result = number;
101			if(value.linear) result = levelvalue.linear;
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-09 19:40 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
102			if(value.poly) result *= Math.floor(Math.pow(level, value.poly));
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-09 19:40 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
103			if(value.exp) result *= Math.floor(Math.pow(value.exp, level));
			0 ignored issues – show Coding Style Best Practice introduced 2017-12-09 19:40 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
104			return result;
105			}
106			}
107			]);
108

angarg12 / nucleogenesis

Push — master ( 0a8aee...45be8d )

angular.service(ꞌutilꞌ) A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like